Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CV GBM: Update cv ntrees in summary table based on best score #7053

Closed
exalate-issue-sync bot opened this issue May 11, 2023 · 3 comments
Closed

CV GBM: Update cv ntrees in summary table based on best score #7053

exalate-issue-sync bot opened this issue May 11, 2023 · 3 comments

Comments

@exalate-issue-sync
Copy link

[https://h2oai.atlassian.net/browse/PUBDEV-8185|https://h2oai.atlassian.net/browse/PUBDEV-8185|smart-link]

The linked story changed how the ntrees of the main model and cv model are selected. I noticed that the ntrees in the cross-validation model summary tables is still based on how many trees were built, and hasn’t been updated to reflect that some trees were removed due to a better score occurring with fewer. I think it would make sense to update this value as well, since it potentially could be pretty different depending on how often the models are being scored.

@exalate-issue-sync
Copy link
Author

Zuzana Olajcová commented: Resolved in [https://github.com//pull/6213|https://github.com//pull/6213|smart-link]

@h2o-ops
Copy link
Collaborator

h2o-ops commented May 14, 2023

JIRA Issue Details

Jira Issue: PUBDEV-8625
Assignee: Zuzana Olajcová
Reporter: Paul Donnelly
State: Resolved
Fix Version: 3.36.1.3
Attachments: N/A
Development PRs: Available

@h2o-ops
Copy link
Collaborator

h2o-ops commented May 14, 2023

Linked PRs from JIRA

#6213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant