Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLM: fix cv_computeAndSetOptimalParameters #7057

Closed
exalate-issue-sync bot opened this issue May 11, 2023 · 4 comments
Closed

GLM: fix cv_computeAndSetOptimalParameters #7057

exalate-issue-sync bot opened this issue May 11, 2023 · 4 comments

Comments

@exalate-issue-sync
Copy link

This ticket deals with 2 bugs in {{cv_computeAndSetOptimalParameters}} .

  • Submodels in different folds can have different {{alpha}}, and {{lambda}} parameters which is a problem since we take the parameters only from the 1st cv model and assume they are the same across the folds.
  • Early stopping in parameter selection in {{cv_computeAndSetOptimalParameters}} is well defined only if there is just one {{alpha}} value which is not always the case.
@exalate-issue-sync
Copy link
Author

Tomas Fryda commented: Performance benchmark results:

!image.png|width=838,height=235!

@h2o-ops
Copy link
Collaborator

h2o-ops commented May 14, 2023

JIRA Issue Details

Jira Issue: PUBDEV-8620
Assignee: Tomas Fryda
Reporter: Tomas Fryda
State: Resolved
Fix Version: 3.36.1.1
Attachments: Available (Count: 1)
Development PRs: Available

@h2o-ops
Copy link
Collaborator

h2o-ops commented May 14, 2023

Attachments From Jira

Attachment Name: image.png
Attached By: Tomas Fryda
File Link:https://h2o-3-jira-github-migration.s3.amazonaws.com/PUBDEV-8620/image.png

@h2o-ops
Copy link
Collaborator

h2o-ops commented May 14, 2023

Linked PRs from JIRA

#6102

@h2o-ops h2o-ops closed this as completed May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants