-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "H2O API Extensions" in h2o.init() output in R and Python #7187
Comments
Michal Kurka commented: We can also hide: Core V3, Core V4, Algos - this is meaningless to the users |
Erin LeDell commented: [~accountid:557058:04659f86-fbfe-4d01-90c9-146c34df6ee6] Ok, I can just keep the following, that’s cleaner, and sort alphabetically: {{Amazon S3, AutoML, Infogram, TargetEncoder, XGBoost}} |
Erin LeDell commented: This data is generated on the backend, and so maybe we should just filter the “extra” ones out on the client side in R and Python in the {{list_api_extensions}} util function: R: [https://github.com/h2oai/h2o-3/blob/dbdcc2b369ade409086626b05989da085c0a9c2b/h2o-r/h2o-package/R/communication.R#L729|https://github.com/h2oai/h2o-3/blob/dbdcc2b369ade409086626b05989da085c0a9c2b/h2o-r/h2o-package/R/communication.R#L729|smart-link] Or we can only filter when printing to to the user in the {{h2o.init()}} printout, such as right here: [https://github.com/h2oai/h2o-3/blob/dbdcc2b369ade409086626b05989da085c0a9c2b/h2o-r/h2o-package/R/communication.R#L795|https://github.com/h2oai/h2o-3/blob/dbdcc2b369ade409086626b05989da085c0a9c2b/h2o-r/h2o-package/R/communication.R#L795|smart-link] and here: [https://github.com/h2oai/h2o-3/blob/36da4fc8b9c9e5baee2aec72a89b99a7d04bc3b5/h2o-py/h2o/backend/cluster.py#L282|https://github.com/h2oai/h2o-3/blob/36da4fc8b9c9e5baee2aec72a89b99a7d04bc3b5/h2o-py/h2o/backend/cluster.py#L282|smart-link] [~accountid:557058:04659f86-fbfe-4d01-90c9-146c34df6ee6] Do you have a preference? My instinct is to filter only at print-out in case we want to use those util functions elsewhere and expect the full list. Another thing i can do is remove underscores from Python printout (key names) to match R. [https://github.com/h2oai/h2o-3/blob/36da4fc8b9c9e5baee2aec72a89b99a7d04bc3b5/h2o-py/h2o/backend/cluster.py#L302-L305|https://github.com/h2oai/h2o-3/blob/36da4fc8b9c9e5baee2aec72a89b99a7d04bc3b5/h2o-py/h2o/backend/cluster.py#L302-L305|smart-link] |
Michal Kurka commented: [~accountid:557058:afd6e9a4-1891-4845-98ea-b5d34a2bc42c] I am thinking we should just completely drop the “H2O API Extensions” line from the output I don’t see how it is useful |
Erin LeDell commented: [~accountid:557058:04659f86-fbfe-4d01-90c9-146c34df6ee6] Ok, I am fine with that. Anything else that we want to get rid of? Do people use the “H2O Internal Security”? I am not sure what that’s for.. |
Michal Kurka commented: I would keep the other stuff - at least for now, it is useful for debugging sometimes The extension list is always the same,users do not add extensions and don’t disable them |
JIRA Issue Details Jira Issue: PUBDEV-8475 |
Attachments From Jira Attachment Name: Screen Shot 2021-12-19 at 7.42.53 PM.png Attachment Name: Screen Shot 2022-01-21 at 12.33.08 PM.png |
Linked PRs from JIRA |
There are too many extensions to fit on one line now, so we need a line break or something to clean up the output. It's too wide for the screen.
{code:java}Starting H2O JVM and connecting: ...................... Connection successful!
R is connected to the H2O cluster:
H2O cluster uptime: 15 seconds 333 milliseconds
H2O cluster timezone: America/Los_Angeles
H2O data parsing timezone: UTC
H2O cluster version: 3.35.0.99999
H2O cluster version age: 16 hours and 44 minutes
H2O cluster name: H2O_started_from_R_me_tnf639
H2O cluster total nodes: 1
H2O cluster total memory: 3.54 GB
H2O cluster total cores: 0
H2O cluster allowed cores: 0
H2O cluster healthy: TRUE
H2O Connection ip: localhost
H2O Connection port: 54321
H2O Connection proxy: NA
H2O Internal Security: FALSE
H2O API Extensions: Amazon S3, XGBoost, Algos, Infogram, AutoML, Core V3, TargetEncoder, Core V4
R Version: R version 4.1.1 (2021-08-10){code}
!Screen Shot 2021-12-19 at 7.42.53 PM.png|width=633,height=553!
The text was updated successfully, but these errors were encountered: