Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrintMojo should allow users to convert floats to doubles #7461

Closed
exalate-issue-sync bot opened this issue May 11, 2023 · 2 comments
Closed

PrintMojo should allow users to convert floats to doubles #7461

exalate-issue-sync bot opened this issue May 11, 2023 · 2 comments

Comments

@exalate-issue-sync
Copy link

Predictions and split values outputted in JSON from PrintMojo are java Floats. However, JSON doesn't preserve type information and without paying extra attention to the issue the parser might interpret the values as Doubles. This would lead in a difference in the prediction based on the json interpreted code and POJO/MOJO/H2O.

To mitigate that we should add an option (--floattodouble) to output Doubles instead of Floats and thus prevent possible parsing issues.

example:

java -cp genmodel.jar hex.genmodel.tools.PrintMojo -i gbm.mojo -o gbm.json --format json --floattodouble

@h2o-ops
Copy link
Collaborator

h2o-ops commented May 14, 2023

JIRA Issue Details

Jira Issue: PUBDEV-8189
Assignee: Michal Kurka
Reporter: Michal Kurka
State: Resolved
Fix Version: 3.34.0.1
Attachments: N/A
Development PRs: Available

@h2o-ops
Copy link
Collaborator

h2o-ops commented May 14, 2023

Linked PRs from JIRA

#5531

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant