Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support predict_contributions for models loaded form MOJO #7478

Closed
exalate-issue-sync bot opened this issue May 11, 2023 · 3 comments
Closed

Support predict_contributions for models loaded form MOJO #7478

exalate-issue-sync bot opened this issue May 11, 2023 · 3 comments

Comments

@exalate-issue-sync
Copy link

{noformat}>>> cars_drf_from_mojo = h2o.import_mojo(cars_drf_mojo)

cars_drf_from_mojo.predict_contributions(valid)
...
OSError: Job with key $03017f00000132d4ffffffff$_9a567cb2f70de208506216676b094fc2 failed with an exception: water.exceptions.H2OIllegalArgumentException: Model type Generic doesn't support calculating Feature Contributions.
stacktrace:
water.exceptions.H2OIllegalArgumentException: Model type Generic doesn't support calculating Feature Contributions.
at water.api.ModelMetricsHandler$1.compute2(ModelMetricsHandler.java:398)
at water.H2O$H2OCountedCompleter.compute(H2O.java:1575)
at jsr166y.CountedCompleter.exec(CountedCompleter.java:468)
at jsr166y.ForkJoinTask.doExec(ForkJoinTask.java:263)
at jsr166y.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:974)
at jsr166y.ForkJoinPool.runWorker(ForkJoinPool.java:1477)
at jsr166y.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:104){noformat}

@exalate-issue-sync
Copy link
Author

Michal Kurka commented: This will be implemented only for the default predict_contributions - the new parameters {{output_format="Original", top_n=None, bottom_n=None, compare_abs=False}} will not be supported in the first version.

These parameters don’t seem to be supported directly in MOJO - we might need to expose them first [~accountid:5f8e6929461cc40075215ee0]

@h2o-ops
Copy link
Collaborator

h2o-ops commented May 14, 2023

JIRA Issue Details

Jira Issue: PUBDEV-8172
Assignee: Michal Kurka
Reporter: Joseph Granados
State: Resolved
Fix Version: 3.34.0.1
Attachments: N/A
Development PRs: Available

@h2o-ops
Copy link
Collaborator

h2o-ops commented May 14, 2023

Linked PRs from JIRA

#5543
#5556
#5566

@h2o-ops h2o-ops closed this as completed May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant