Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a num_of_features argument to h2o.varimp_heatmap function #7634

Closed
exalate-issue-sync bot opened this issue May 11, 2023 · 3 comments
Closed

Add a num_of_features argument to h2o.varimp_heatmap function #7634

exalate-issue-sync bot opened this issue May 11, 2023 · 3 comments
Assignees

Comments

@exalate-issue-sync
Copy link

We forgot to add a limit on the number of variables that are displayed by default in {{h2o.varimp_heatmap()}} Let's add a new param called {{num_of_features}} since that's the name of the param used in {{h2o.varimp_plot()}}. The default there is 10 -- but maybe a good default in the heatmap is 20, since that's the number of models we display by default, and so then the heatmap will have nice square boxes(?). We can play around with it and see what looks best.

In R’s {{h2o.varimp_plot()}}, we have the default set to {{NULL}} in the function (and it will show at most 10 by default). That might be because someone thought that putting {{ = 10}} would be misleading (if there are less than 10 features), but I think it’s actually better to have the integer hardcoded as default. We set the default for {{top_n}} in {{h2o.varimp_heatmap()}} to 20, so for consistency let’s use an integer instead of {{NULL}}. We could also consider changing the default from {{NULL}} to {{10}} in {{h2o.varimp_plot()}} too….

This should be added to both R and Python.

@h2o-ops
Copy link
Collaborator

h2o-ops commented May 14, 2023

JIRA Issue Details

Jira Issue: PUBDEV-8014
Assignee: Tomas Fryda
Reporter: Erin LeDell
State: Resolved
Fix Version: 3.36.1.1
Attachments: Available (Count: 1)
Development PRs: Available

@h2o-ops
Copy link
Collaborator

h2o-ops commented May 14, 2023

Attachments From Jira

Attachment Name: Screen Shot 2021-02-19 at 1.31.56 PM.png
Attached By: Erin LeDell
File Link:https://h2o-3-jira-github-migration.s3.amazonaws.com/PUBDEV-8014/Screen Shot 2021-02-19 at 1.31.56 PM.png

@h2o-ops
Copy link
Collaborator

h2o-ops commented May 14, 2023

Linked PRs from JIRA

#5674

@h2o-ops h2o-ops closed this as completed May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants