Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in feature_interaction() for GBM in gain value #7736

Closed
exalate-issue-sync bot opened this issue May 11, 2023 · 2 comments
Closed

Bug in feature_interaction() for GBM in gain value #7736

exalate-issue-sync bot opened this issue May 11, 2023 · 2 comments
Labels
fixVersion/3.32.1.1

Comments

@exalate-issue-sync
Copy link

during the calculation, there is error in how gain is extracted from nodes squared error:

currently it is like gain += node.squaredError

but should be like "presplit - split" squared error

gain += node.sguaredError - node.leftChild.squaredError - node.rightChild.squaredError

this error is then propagated recursively through whole calculation.
@exalate-issue-sync
Copy link
Author

Zuzana Olajcová commented: Resolved in #5141

@h2o-ops
Copy link
Collaborator

h2o-ops commented May 14, 2023

JIRA Issue Migration Info

Jira Issue: PUBDEV-7909
Assignee: Zuzana Olajcová
Reporter: Zuzana Olajcová
State: Resolved
Fix Version: 3.32.1.1
Attachments: N/A
Development PRs: Available

Linked PRs from JIRA

#5141

@h2o-ops h2o-ops closed this as completed May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixVersion/3.32.1.1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@h2o-ops