Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k-LIME easy predict wrapper should use Regression or KLime as a model category instead of just KLime #8012

Closed
exalate-issue-sync bot opened this issue May 11, 2023 · 1 comment
Closed

k-LIME easy predict wrapper should use Regression or KLime as a model category instead of just KLime #8012

exalate-issue-sync bot opened this issue May 11, 2023 · 1 comment
Labels
fixVersion/3.30.1.2

Comments

@exalate-issue-sync
Copy link

More info here: https://github.com/h2oai/h2o-3/pull/4618/files#r442554040

Summary:

EasyPredictModelWrapper#predictKLime overrides getModelCategories - here we pass ModelCategory.KLime which is checked against KLime#getModelCategories which returns [Regression]. There is a workaround for this by overriding, but we should fix in h2o-3, as well.
@h2o-ops
Copy link
Collaborator

h2o-ops commented May 14, 2023

JIRA Issue Migration Info

Jira Issue: PUBDEV-7627
Assignee: Navdeep Gill
Reporter: Navdeep Gill
State: Resolved
Fix Version: 3.30.1.2
Attachments: N/A
Development PRs: Available

Linked PRs from JIRA

#4735
https://github.com/h2oai/mojo2/pull/999

@h2o-ops h2o-ops closed this as completed May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixVersion/3.30.1.2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@h2o-ops