Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target encoder does not unlock output Frame #8196

Closed
exalate-issue-sync bot opened this issue May 11, 2023 · 3 comments
Closed

Target encoder does not unlock output Frame #8196

exalate-issue-sync bot opened this issue May 11, 2023 · 3 comments

Comments

@exalate-issue-sync
Copy link

In the original TargetEncoder.java file, there is a method named "updateDomainGlobally", which locks a frame on its vector update, however the lock is not released afterwards.

@exalate-issue-sync
Copy link
Author

Andrey Spiridonov commented: This is a duplicate for already reported issue [https://0xdata.atlassian.net/browse/PUBDEV-7434?filter=-2|https://0xdata.atlassian.net/browse/PUBDEV-7434?filter=-2|smart-link] . Just not to forget to close them both.

@exalate-issue-sync
Copy link
Author

Andrey Spiridonov commented: {quote}which locks a frame on its vector update, however the lock is not released afterwards.{quote}

I believe it would be fair to say that lock is being unlocked in the code, but maybe there is some issue within locking/unlocking mechanism itself. We still don’t have a prove that suggested fix ( different way to lock/unlock) will not break existing tests in a multinode setting. Even if it does help us in this particular scenario there still is a room for investigation on what is happening with locks.

@h2o-ops
Copy link
Collaborator

h2o-ops commented May 14, 2023

JIRA Issue Migration Info

Jira Issue: PUBDEV-7441
Assignee: Pavel Pscheidl
Reporter: Pavel Pscheidl
State: Closed
Fix Version: 3.30.0.2
Attachments: N/A
Development PRs: Available

Linked PRs from JIRA

#4501

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant