Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XGBoost and Naive Bayes to metalearner_algorithm options in Stacked Ensemble #8674

Closed
exalate-issue-sync bot opened this issue May 12, 2023 · 6 comments

Comments

@exalate-issue-sync
Copy link

We should have all the available supervised algos as options for the metalearner algorithm. Currently its hardcoded to this list:

{quote}{{metalearner_algorithm = c("AUTO", "glm", "gbm", "drf", "deeplearning")}}{quote}

Should be:

{quote}{{metalearner_algorithm = c("AUTO", "glm", "gbm", "drf", "deeplearning", "xgboost", "naivebayes", "psvm",)}}{quote}

@exalate-issue-sync
Copy link
Author

Erin LeDell commented: I removed “PSVM” from the title because we had to remove the algo from the list of metalearner options until a bug is fixed. [https://github.com//pull/4341|https://github.com//pull/4341|smart-link]

@exalate-issue-sync
Copy link
Author

Abhinav Sharma commented: Hi team,

It seems that the {{naivebayes}} and {{xgboost}} meta-learners , the stacked ensemble does not accept the {{metalearner_params}} option at all with {{v3.30.0.4}}

{quote}Moreover, for the stacked ensemble with {{xgboost}} meta-learner it is not even possible to inspect the metalearner via {{se_model_with_xgb_metalearner.metalearner()}} as it throws an error.
{quote}

UPDATE: Whoops, for the second part I realized it’s because I was inspecting the model on a windows machine.

@exalate-issue-sync
Copy link
Author

Abhinav Sharma commented: Would you prefer that I create a bug report for this?

@exalate-issue-sync
Copy link
Author

Erin LeDell commented: [~accountid:557058:d55d2d14-5709-435a-be18-0436a70f4414] Thanks for the report. If you can, a new/separate Jira with an example would be great! (Otherwise we can create one).

@exalate-issue-sync
Copy link
Author

Abhinav Sharma commented: @erin, I’ve created and explained the task over here

[https://h2oai.atlassian.net/browse/PUBDEV-7907|https://h2oai.atlassian.net/browse/PUBDEV-7907|smart-link]

P.S. Thanks for the great work on Stacked Ensembles and H2O, I’ve learnt a lot from your thesis and subsequent work!

@h2o-ops
Copy link
Collaborator

h2o-ops commented May 14, 2023

JIRA Issue Migration Info

Jira Issue: PUBDEV-6965
Assignee: Sebastien Poirier
Reporter: Erin LeDell
State: Resolved
Fix Version: 3.28.0.4
Attachments: N/A
Development PRs: Available

Linked PRs from JIRA

#4273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant