GH-15972: Add Option Filtering File System For Reading and Writing #16057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@krasinski The PR looks good to me, good job! Can you also add some docs.? |
krasinski
requested review from
wendycwong,
valenad1,
maurever,
sebhrusen,
tomasfryda and
syzonyuliia
wendycwong
approved these changes
Feb 13, 2024
wendycwong
requested changes
Feb 16, 2024
| throw new IllegalArgumentException("Error parsing file_deny_glob parameter"); | ||
| } | ||
| } | ||
| else if(s.matches("embedded")) { |
There was a problem hiding this comment.
@krasinski : This seems to significantly slow down H2O. Is it possible to do this check less frequently? Like when there is a actual reading/writing that is about to happen rather than any time someone wants to look at the key?
There was a problem hiding this comment.
@krasinski : It seems like my previous comment was wrong. The failure is probably caused by error throws by worker node not caught and the whole test just hang. Here is a copy of the test run time:
wendycwong
previously approved these changes
Feb 20, 2024
tomasfryda
previously approved these changes
Feb 21, 2024
krasinski
dismissed stale reviews from tomasfryda and wendycwong
via
02cb709
wendycwong
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #15972