[ITA-344] Build Python package under h2o-py/build/. #2881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubhava
reviewed
Sep 25, 2018
h2o-py/build.gradle
Outdated
| file("${projectDir}/dist/").mkdirs() | ||
| copy { | ||
| from "${buildDir}/dist/*.whl" | ||
| into "${projectDir}/dist/" |
There was a problem hiding this comment.
This breaks what we want to achieve here. All generated artifacts should be stored in disposable directory build.
I would just keep the distribution in build/dist and would not copy it anywhere else. Having everything in build makes the clean work properly
There was a problem hiding this comment.
Should be removed, thanks @jakubhava.
jakubhava
approved these changes
Sep 26, 2018
michalkurka
approved these changes
Oct 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build the Python package inside
h2o-py/builddirectory. The idea is to keep the source files intact, and do everything build related in thebuilddirectory.