Eliminate generating another extra jar which is not used for each h2o-hadoop #3006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Feel free to merge if you're ok with this change after your review. I might be on holidays already |
michal-raska
approved these changes
Nov 2, 2018
|
I also upgraded shadow jar to 4.0.2 as that speeds up generating shadowJar of Hadoop to 34 seconds from 100 seconds @michal-raska. Checked the files and they are identical |
|
Cool! |
jakubhava
force-pushed
the
jh/remove/extra_jar
branch
from
2911ccf
to
33d58ee
Compare
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use just the shadow JAR. The
jarprovided byjavaplugin is generated and never used. Less artifacts and should also speed the build a bit