PUBDEV-6376: StackedEnsemble prediction fails when applied to a test dataset without response column #3382
Conversation
… direct access to original frame (like in SE scoring)
|
@michalkurka please have a look: tiny fix but very important! thx |
| @@ -1452,7 +1452,7 @@ protected Frame predictScoreImpl(Frame fr, Frame adaptFrm, String destination_ke | |||
| GLMScore gs = makeScoringTask(adaptFrm,true,j);// doAll(names.length,Vec.T_NUM,adaptFrm); | |||
| assert gs._dinfo._valid:"_valid flag should be set on data info when doing scoring"; | |||
| gs.doAll(names.length,Vec.T_NUM,gs._dinfo._adaptedFrame); | |||
| if (gs._computeMetrics) | |||
| if (computeMetrics && gs._computeMetrics) | |||
There was a problem hiding this comment.
It seems like a better fix would be to propagate the flag to makeScoringTask - because GLMScore will actually run _mb.perRow to prepare the metadata for the metrics but this won't be used anywhere
to me that means we should let GLMScore know we don't need the metrics
There was a problem hiding this comment.
@michalkurka: yes, wanted to minimize changes but this would be more robust.
Will propagate then.
|
I think the GLM change makes sense. However, why does GLM thinks it does have a response when SE doesn't? |
|
for documentation purpose, answering @michalkurka question as we had a separate discussion about GLM behaviour: |
|
underlying cause fixed in #3383 we shouldn't need this urgently anymore fix makes sense, I would just clean-up the naming computeMetrics vs computeMetrix |
https://0xdata.atlassian.net/browse/PUBDEV-6376
ensured that GLM respect computeMetrics parameter when it doesn't have direct access to original frame (like in SE scoring)