PUBDEV-6447 constrained kmeans POC #4067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurever
force-pushed
the
maurever_PUBDEV-6447_constrained_kmeans
branch
from
bccb82c
to
6e11999
Compare
maurever
force-pushed
the
maurever_PUBDEV-6447_constrained_kmeans
branch
from
a67e5e4
to
93b9806
Compare
honzasterba
reviewed
Dec 4, 2019
michalkurka
reviewed
Dec 9, 2019
|
@angela0xdata, could you review the documentation part of this PR, please? Thank you! |
michalkurka
reviewed
Dec 9, 2019
michalkurka
approved these changes
Dec 9, 2019
ABartzGit
reviewed
Dec 9, 2019
h2o-r/h2o-package/R/kmeans.R
Outdated
| @@ -36,6 +36,8 @@ | |||
| #' @param categorical_encoding Encoding scheme for categorical features Must be one of: "AUTO", "Enum", "OneHotInternal", "OneHotExplicit", | |||
| #' "Binary", "Eigen", "LabelEncoder", "SortByResponse", "EnumLimited". Defaults to AUTO. | |||
| #' @param export_checkpoints_dir Automatically export generated models to this directory. | |||
| #' @param cluster_size_constraints Specify how many points should be at least in each cluster. The length of constraints array has to be same as | |||
There was a problem hiding this comment.
minor edit:
Specify how many points should be at least in each cluster. The length of constraints array must be the same as the number of clusters (experimental).
|
@maurever, I added a simple example to h2o-bindings/bin/custom/python/gen_kmeans.py (similar to other KMeans options). |
ABartzGit
approved these changes
Dec 9, 2019
No, it is ok. My code causes the fail of the test. Thank you very much for your improvements and review @angela0xdata! |
Pscheidl
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constrained K-means - Experimental
Calculate K-means using the minimal size of cluster constrain.
Implemented according to https://pdfs.semanticscholar.org/ecad/eb93378d7911c2f7b9bd83a8af55d7fa9e06.pdf
JIRA: https://0xdata.atlassian.net/projects/PUBDEV/issues/PUBDEV-6447
Currently implemented an only serial version of minimal cost flow calculation. A map-reduce version will be implemented soon.
EDIT:
-> assign as experimental
-> remove from Python/R API
-> remove Doc