Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PUBDEV-7914] grid with failing CV models would hang indefinitely #5183

Merged
merged 3 commits into from
Dec 12, 2020

Conversation

honzasterba
Copy link
Contributor

Copy link
Contributor

@michalkurka michalkurka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Moving the callback to the driver level resolves the issue with the callback being triggered for CV models as well as the user reported issue.

This fits the use case of parallel grid search. Do you see a need for the original more powerful API in the future - callback also for CV models (eg. releasing GPUs to make available to the next model builder)?

@honzasterba
Copy link
Contributor Author

This fits the use case of parallel grid search. Do you see a need for the original more powerful API in the future - callback also for CV models (eg. releasing GPUs to make available to the next model builder)?

cv model build uses a different approach, but this API would be usable for that if we wanted to improve the performance of CV model builidng

@honzasterba honzasterba merged commit 12f6e81 into rel-zermelo Dec 12, 2020
@honzasterba honzasterba deleted the honza/PUBDEV-7914/parallel_grid_cv_fail branch December 12, 2020 10:13
flaviusburca pushed a commit to mware-solutions/h2o-3 that referenced this pull request Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants