Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PUBDEV-8349: Fix infinite loop in hex.grid.HyperSpaceWalker.RandomDiscreteValueWalker #5785

Merged
merged 3 commits into from
Oct 1, 2021
Merged

PUBDEV-8349: Fix infinite loop in hex.grid.HyperSpaceWalker.RandomDiscreteValueWalker #5785

merged 3 commits into from
Oct 1, 2021

Conversation

tomasfryda
Copy link
Contributor

@tomasfryda tomasfryda self-assigned this Sep 24, 2021
@tomasfryda tomasfryda force-pushed the tomf_fix_infinite_loop_in_hyperspace_walker branch from 215eee5 to ad01a53 Compare September 24, 2021 13:44
@tomasfryda tomasfryda force-pushed the tomf_fix_infinite_loop_in_hyperspace_walker branch from ad01a53 to 67e41af Compare September 24, 2021 13:58
@tomasfryda tomasfryda force-pushed the tomf_fix_infinite_loop_in_hyperspace_walker branch from 4c4fbc0 to 93cf037 Compare September 29, 2021 15:33
@tomasfryda tomasfryda force-pushed the tomf_fix_infinite_loop_in_hyperspace_walker branch from 93cf037 to 238d81a Compare September 29, 2021 15:38
sebhrusen
sebhrusen reviewed Sep 29, 2021
View reviewed changes
Copy link
Contributor

@sebhrusen sebhrusen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

h2o-core/src/main/java/hex/grid/HyperSpaceWalker.java Outdated
* @param maxModels
* @return estimate of grid work
*/
default long getGridWork(long maxModels) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: let's name it for what it is, estimateGridWork (?) and keep get__ for property getters.

@sebhrusen sebhrusen self-requested a review September 29, 2021 15:52
sebhrusen
sebhrusen approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@sebhrusen sebhrusen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This signs the end of infinity, maybe Giordano Bruno deserved to be burned after all…

Thanks @tomasfryda

@tomasfryda tomasfryda merged commit 924ac33 into rel-zizler Oct 1, 2021
@tomasfryda tomasfryda deleted the tomf_fix_infinite_loop_in_hyperspace_walker branch October 1, 2021 09:21
@h2o-ops-ro h2o-ops-ro mentioned this pull request May 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebhrusen sebhrusen sebhrusen approved these changes

Assignees

@tomasfryda tomasfryda

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tomasfryda @sebhrusen