PUBDEV-8425: Add option to mimic "ActiveProcessorCount" for older JVMs #5898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mn-mikke
reviewed
Nov 19, 2021
There was a problem hiding this comment.
What about LinuxProcFileReader.getProcessCpusAllowed()? Shouldn't it be also modified?
This is on purpose, this method reads the information directly from the OS and bypasses java on Linux. This also means that specifying JVM option It should be kept as-is but maybe I need to add a comment explaining why it is done this way. |
mn-mikke
approved these changes
Nov 19, 2021
michalkurka
force-pushed
the
michalk_h2o-runtime
branch
from
d4ef86f
to
9830fc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.