Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PUBDEV-8485 UpliftDRF: Add Qini value metric #6031

Merged
merged 14 commits into from
Feb 21, 2022
Merged

PUBDEV-8485 UpliftDRF: Add Qini value metric #6031

merged 14 commits into from
Feb 21, 2022

Conversation

maurever
Copy link
Contributor

@maurever maurever commented Jan 24, 2022 •
edited
Loading

@maurever maurever self-assigned this Jan 24, 2022
@maurever maurever changed the base branch from master to rel-zorn January 24, 2022 16:17
@maurever maurever force-pushed the maurever_PUBDEV-8485_add_qini_metric branch from 92bf2ef to 4356601 Compare February 7, 2022 20:03
@maurever maurever changed the title PUBDEV-8485 UpliftDRF: Add Qini metric PUBDEV-8485 UpliftDRF: Add Qini value metric Feb 7, 2022
valenad1
valenad1 previously requested changes Feb 11, 2022
View reviewed changes
Copy link
Collaborator

@valenad1 valenad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Can you check the examples please? I checked only Python but maybe in R is also some mistake.

@maurever
Copy link
Contributor Author

Thanks @valenad1, the example bugs were fixed here: cd7fbe6

@maurever maurever dismissed valenad1’s stale review February 18, 2022 20:23

To ask for new one.

valenad1
valenad1 requested changes Feb 20, 2022
View reviewed changes
Copy link
Collaborator

@valenad1 valenad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the examples except one works for me now, thanks 👍 plot_uplift in python is still raising error for me.

valenad1
valenad1 approved these changes Feb 21, 2022
View reviewed changes
Copy link
Collaborator

@valenad1 valenad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its working! Thank you 👍

@maurever maurever merged commit 1e7e366 into rel-zorn Feb 21, 2022
@maurever maurever deleted the maurever_PUBDEV-8485_add_qini_metric branch February 21, 2022 13:17
@h2o-ops-ro h2o-ops-ro mentioned this pull request May 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valenad1 valenad1 valenad1 approved these changes

@koniecsveta koniecsveta koniecsveta approved these changes

@michalkurka michalkurka michalkurka approved these changes

Assignees

@maurever maurever

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maurever @valenad1 @koniecsveta @michalkurka