PUBDEV-8692: DKV - Remove key-replicas from API #6178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalkurka
force-pushed
the
michalk_no-replicas
branch
from
5092667
to
6c74296
Compare
Key.make(string, systemKey, required=true) doens't make sense because there is no home node given => remove and keep only Key.make(string, systemKey) with implicit required=false
michalkurka
force-pushed
the
michalk_no-replicas
branch
from
6c74296
to
d50977a
Compare
sebhrusen
approved these changes
Apr 28, 2022
michalkurka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the Key API without any intended (!) changes in functionality.
The current Key API exposed the concept of replication factor and also homing keys to multiple replicas. This is however deprecated and unused.
Changes:
FIY: @sebhrusen I am working on a POC of cluster resiliency that would require changes in the Key distribution function - this is therefore done to simplify the logic, remove dead code and keep only stuff that is actually needed/used.