Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CODE IMPROVEMENT] Reduce too verbose logging on startup #372

Closed
maxjeblick opened this issue Aug 16, 2023 · 0 comments 路 Fixed by #373
Closed

[CODE IMPROVEMENT] Reduce too verbose logging on startup #372

maxjeblick opened this issue Aug 16, 2023 · 0 comments 路 Fixed by #373
Assignees
Labels
area/core Core code related issue

Comments

@maxjeblick
Copy link
Contributor

馃敡 Proposed code refactoring

Reduce logging on startup in case experiment config yaml has keys that do not match the current dataclass.

When starting the app, get_experiments(q) goes trough all experiments and loads the config yaml.
In case experiment configuration dataclasses code has been changed (as it has been the case recently), the startup logs can be polluted with

2023-08-16 17:56:12,061 - WARNING: Keys {'reward_model', 'ppo_clip_policy', 'advantages_gamma', 'ppo_epochs', 'kl_target', 'use_rlhf', 'initial_kl_coefficient', 'ppo_batch_size', 'adaptive_kl_control', 'scaling_factor_value_loss', 'offload_reward_model', 'advantages_lambda', 'ppo_generate_temperature', 'kl_horizon', 'ppo_clip_value'} are not in the config.
2023-08-16 17:56:12,061 - WARNING: Keys {'number_of_texts'} are not in the config.

Motivation

Remove the startup warnings as

  • It is unclear where these warning exactly comes from and what to do
  • Warning should only be present when a user starts an experiment from a configuration (or old experiment) that has unseen keys.
@maxjeblick maxjeblick added the area/core Core code related issue label Aug 16, 2023
@maxjeblick maxjeblick self-assigned this Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core Core code related issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant