Enhancements to Secret Management

[maxjeblick]

This pull request adds different backend handlers for storing passwords with keyring being the default.
On systems where keyring fails, it is possible to select a local .env backend, or not to save the tokens at all.

Purpose
The purpose of these changes is to provide the application with greater flexibility and security when it comes to managing and storing sensitive information.

Backward compatibility
A migration process is implemented that converts the old pickle format.
On systems where migration to keyring fails, the user needs to manually reenter missing tokens (this is mentioned in the logs).

Fixes #363

[fatihozturkh2o]

2023-08-16 03:36:58,099 - INFO: Could not migrate tokens. Please delete /home/fatih/h2o-llmstudio/data/dbs/anon.settings and set your credentials again.Error:

This warning is expected, see the code for migration. It basically means that keyring storage fails (as it is the case on our remote machines, I wasn't able to configure keyring). The old settings are not deleted in this case.

I'm also happy for suggestions how to better handle this, e.g. using a pop-up that informs the user.

The other warnings ... are not in the config are unrelated to the PR.

I see. So the warnings are from the main branch?

[maxjeblick]

I see. So the warnings are from the main branch?

Yes, they arise when calling load_config_yaml. Probably better to make the warning more explicit.

[fatihozturkh2o]

I see. So the warnings are from the main branch?

Yes, they arise when calling load_config_yaml. Probably better to make the warning more explicit.

they seem to be spamming the logs though. Here I just clicked Home while running my experiment:

[maxjeblick]

Created an issue for tracking: #372

[fatihozturkh2o]

lgtm!

(you might consider adding type annotation for what the following two functions return though: _get_secrets_handler, _get_usersettings_path)

[pascal-pfeiffer]

Thank you for this security related upgrade, @maxjeblick

I still ran into issues when just upgrading to the PR branch, but using a clean environment everything was working fine. I think we can live with that.

lgtm

[maxjeblick]

Sorry for the late reply @pascal-pfeiffer, I ran into some new timeout issues after I tried to configure keyring on the remote machine. Compared to the reviewed PR, I added the following:

• Default credential_saver was changed to .env file to avoid any keyring issues. This should allow for migration without issues.
• Keyring handler will be disabled if it is not configured correctly (keyring.get_password fails for some reason). While this adds up to 3 seconds time overhead when starting the app, it will safeguard against potential hang-ups.
• I fixed merge conflicts with latest main

Please feel free to re-review the changes.