Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add deepspeed checks #465

Merged
merged 4 commits into from Oct 24, 2023
Merged

add deepspeed checks #465

merged 4 commits into from Oct 24, 2023

Conversation

maxjeblick
Copy link
Contributor

@maxjeblick maxjeblick commented Oct 24, 2023 •
edited

Adds deepspeed config checks. I've left the corresponding asserts in run to catch any issues when using CLI.
Also fixed some mypy errors.

Fixes #463

pascal-pfeiffer
pascal-pfeiffer approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@pascal-pfeiffer pascal-pfeiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maxjeblick maxjeblick merged commit e6c7606 into main Oct 24, 2023
5 checks passed
@maxjeblick maxjeblick deleted the max/cfg_checks_deepspeed branch October 24, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascal-pfeiffer pascal-pfeiffer pascal-pfeiffer approved these changes

@leecming82 leecming82 Awaiting requested review from leecming82

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CODE IMPROVEMENT] Add config checks for deepspeed
2 participants
@maxjeblick @pascal-pfeiffer