Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rlhf regression #472

Merged
merged 4 commits into from
Oct 25, 2023
Merged

fix rlhf regression #472

merged 4 commits into from
Oct 25, 2023

Conversation

pascal-pfeiffer
Copy link
Collaborator

maxjeblick
maxjeblick approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@maxjeblick maxjeblick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I owe you one!

@pascal-pfeiffer pascal-pfeiffer merged commit 3fc2031 into main Oct 25, 2023
5 checks passed
@pascal-pfeiffer pascal-pfeiffer deleted the pp/fix_rlhf_regression branch October 25, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxjeblick maxjeblick maxjeblick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pascal-pfeiffer @maxjeblick