Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor classification ds #481

Merged
merged 10 commits into from Nov 14, 2023
Merged

Refactor classification ds #481

merged 10 commits into from Nov 14, 2023

Conversation

maxjeblick
Copy link
Contributor

Some (mild) refactoring of Causal Classification Problem Type:

  • Removed some inference settings that are not needed for classification (all generation related settings). Fixed several parts code such that it will work with the changes.
  • Extracted a separate Dataset class for Causal Classification.
  • Chat Tab will not be displayed when using Causal Classification.
  • Fixed a (non reported) issue and removed not needed methods in the metric classes .

Copy link
Collaborator

@psinger psinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Max and sorry for review delay.

I couldn't find any issues, lgtm!

@maxjeblick maxjeblick merged commit 75acecf into main Nov 14, 2023
5 checks passed
@maxjeblick maxjeblick deleted the max/refactor_classification_ds branch November 14, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants