Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update lib #617

Merged
merged 2 commits into from Feb 28, 2024
Merged

update lib #617

merged 2 commits into from Feb 28, 2024

Conversation

haqishen
Copy link
Collaborator

@haqishen haqishen commented Feb 22, 2024

Check

  • docker runtime
  • flash-attn

@maxjeblick maxjeblick self-requested a review February 26, 2024 12:15
@maxjeblick
Copy link
Contributor

test_generation_is_the_same_as_for_causal_language_modeling is failing.
I assume that huggingface/transformers@3f60d11 is the root of the issue (this line):

causal_mask[..., :mask_length].eq(0.0) * attention_mask[:, None, None, :].eq(0.0)
Traceback (most recent call last):
  File "/home/max/.local/share/JetBrains/Toolbox/apps/pycharm-professional/plugins/python/helpers-pro/pydevd_asyncio/pydevd_asyncio_utils.py", line 114, in _exec_async_code
    result = func()
  File "<input>", line 1, in <module>
RuntimeError: The size of tensor a (64) must match the size of tensor b (136) at non-singleton dimension 3

Will try to create a minimal example that reproduces this error and potentially create an issue in transformers library.

@maxjeblick
Copy link
Contributor

maxjeblick commented Feb 26, 2024

I've resolved the issue that originated from code changes in the transformers library that required config.max_position_embeddings = 1024 (before it was 32) in MaxJeblick/llama2-0b-unit-test.

Copy link
Contributor

@maxjeblick maxjeblick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the upgrade!
I've tested with several models (including flash attention), looks good!

@pascal-pfeiffer pascal-pfeiffer merged commit 48195c5 into main Feb 28, 2024
@pascal-pfeiffer pascal-pfeiffer deleted the upgrade_lib_2402 branch February 28, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants