Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try transformers experimental streaming. Still uses threads, so probably won't fix browser exit GPU memory issue #98

Merged
merged 12 commits into from
May 2, 2023

Conversation

pseudotensor
Copy link
Collaborator

@pseudotensor pseudotensor commented Apr 29, 2023

One this is fixed: gradio-app/gradio#4016 then can incorporate that and rely upon stopping to clear activate generate instead of just waiting for those threads to finish.

@pseudotensor pseudotensor marked this pull request as ready for review May 2, 2023 03:27
@pseudotensor
Copy link
Collaborator Author

pseudotensor commented May 2, 2023

High concurrency (10) runs fine (just slower), no more memory.

image

and hit this:

#104

this breaks a given user. But maybe that's ok, but seems should be recoverable even for that user.

…input, including nochat, with accounting of inputs used (nochat uses text box for instruction/iinput, while chat uses history).
@pseudotensor pseudotensor merged commit 321b64c into main May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

if user exits browser or tab, gradio not cleaning up process/threads
1 participant