Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Airgap support. #122

Merged
merged 1 commit into from
May 23, 2023
Merged

feat: Airgap support. #122

merged 1 commit into from
May 23, 2023

Conversation

mturoci
Copy link
Collaborator

@mturoci mturoci commented May 16, 2023

Copied over previous (ultra-optimized) implementation that divides fonts based on unicode characters. Saving a few kbs compared to a few MB main bundle may seem like an overkill, but I wanted to keep Nitro working as before with no changes.

@mturoci mturoci requested a review from lo5 as a code owner May 16, 2023 11:26
Copy link
Member

@lo5 lo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mturoci!

@lo5 lo5 merged commit e1275c0 into main May 23, 2023
4 checks passed
@lo5 lo5 deleted the feat/airgap-support branch May 23, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants