Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: 🔒Enable and enforce boringcrypto experiment #126

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

zoido
Copy link
Contributor

@zoido zoido commented Jun 27, 2024

GOEXPERIMENT=boringcrypto switches crypto packages to call BoringCrypto library. It is included as a precompiled object with Go distibution so can be linked to statically.

We want to have all binaries consistently built this way to get closer to FIPS 140 compliance.


I needed to change the ldflags in the .goreleaser.yaml as the default contains -s and we want to have symbol table preset as it is the only way how can verify that the binary is buit the way we want.

There's no obvious way how the toolchain version is specified so just FYI, GOEXPERIMENT=boringcrypto requires atleast Go 1.19.

…Crypto library. It is included as a precompiled object with Go distibution so can be linked to statically.

We want to have all  binaries consistently built this way to get closer to FIPS 140 compliance.

---

I needed to change the ldflags in the `.goreleaser.yaml` as the default contains `-s` and we want to have symbol table preset as it is the only way how can verify that the binary is buit the way we want.

There's no obvious way how the toolchain version is specified so just FYI, `GOEXPERIMENT=boringcrypto` requires atleast Go 1.19.
@zoido zoido changed the title GOEXPERIMENT=boringcrypto switches crypto packages to call BoringCrypto library. It is included as a precompiled object with Go distibution so can be linked to statically. build: 🔒Enable and enforce boringcrypto experiment Jun 27, 2024
@zoido zoido marked this pull request as ready for review June 27, 2024 15:59
@zoido zoido requested a review from lo5 as a code owner June 27, 2024 15:59
@lo5 lo5 merged commit 23927cd into h2oai:main Jul 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants