Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getting of sparkling water jar in pysparkling #3898

Closed
exalate-issue-sync bot opened this issue May 22, 2023 · 5 comments
Closed

Fix getting of sparkling water jar in pysparkling #3898

exalate-issue-sync bot opened this issue May 22, 2023 · 5 comments
Assignees

Comments

@exalate-issue-sync
Copy link

No description provided.

@exalate-issue-sync
Copy link
Author

Michal Malohlava commented: Any bug report in this context? Was zip incorrectly detected in binary distribution or after pip installation?

@exalate-issue-sync
Copy link
Author

Jakub Hava commented: yes - old jar was stored in the cache and python was using it even on different version, which was causing several issues because of the class inconsistency. It happened to me today when switching between versions.

@exalate-issue-sync
Copy link
Author

Jakub Hava commented: I can revert the non-zip part, but I still think the files shouldn't be cached as it will cause problems when moving between different versions.

This could be fixed by adding version to sparkling-water.jar in zip, but in order to check the version we would need to extract version file out of the zip anyway.

@DinukaH2O
Copy link

JIRA Issue Migration Info

Jira Issue: SW-436
Assignee: Jakub Hava
Reporter: Jakub Hava
State: Resolved
Fix Version: 2.0.9
Attachments: N/A
Development PRs: Available

Linked PRs from JIRA

#280

@hasithjp
Copy link
Member

JIRA Issue Migration Info Cont'd

Jira Issue Created Date: 2017-05-18T06:42:19.733-0700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants