getFeaturesCols() should not return the fold column or weight column

[exalate-issue-sync]

Currently the getFeaturesCols will return the fold column and the weights column. We should update this method so that it only returns columns that are used to train on.

[exalate-issue-sync]

Jakub Hava commented: It should provably print warning, letting the user know about this behavior.

Also, from data science point of view, [~accountid:557058:eac185dd-5a5c-46e9-bb5a-13217ee9c218], can you verify that excluding these 2 columns for scoring does make sense? I don't have the DS background. Thanks!

[exalate-issue-sync]

Lauren DiPerna commented: hi [~accountid:557058:eeeb611c-665e-431d-b442-1f255171db6f] yes I think it makes sense to exclude these two columns from a DS perspective, because the fold column and weights column shouldn't be used as features during training, and the fold column in particular shouldn't be required during scoring. hope this helps!

[exalate-issue-sync]

Jakub Hava commented: Cool! thank you [~accountid:557058:eac185dd-5a5c-46e9-bb5a-13217ee9c218]. This change will overlap with big API clean up introduced by SW-1231 ( will go into major release)

[exalate-issue-sync]

Marek Novotny commented: PR: #1177

[DinukaH2O]

JIRA Issue Migration Info

Jira Issue: SW-1248
Assignee: Marek Novotny
Reporter: Lauren DiPerna
State: Resolved
Fix Version: 2.1.54
Attachments: N/A
Development PRs: Available

Linked PRs from JIRA

#1177
#1183
#1204

[hasithjp]

JIRA Issue Migration Info Cont'd

Jira Issue Created Date: 2019-04-25T17:40:22.836-0700