[SW-1211] Automatically download H2O Wheel during build #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for tests |
mn-mikke
reviewed
Apr 17, 2019
py/build.gradle
Outdated
| @@ -17,6 +17,7 @@ ext { | |||
| pkgDir = file("$buildDir/pkg") | |||
| distDir = file("$buildDir/dist") | |||
| condaDir = file("$buildDir/conda/h2o_pysparkling_${sparkMajorVersion}") | |||
| wheelFile = file("${rootDir.toString()}/.gradle/wheels/h2o-${h2oMajorVersion}.${h2oBuild}-py2.py3-none-any.whl") | |||
There was a problem hiding this comment.
Is .toString() necessary here?
There was a problem hiding this comment.
it will resolve to string automatically
py/build.gradle
Outdated
| } else if (H2O_PYTHON_WHEEL != null) { | ||
| copyH2OFromH2OWheel(H2O_PYTHON_WHEEL) | ||
| } else { | ||
| copyH2OFromH2OWheel(H2O_PYTHON_WHEEL.toString()) |
There was a problem hiding this comment.
Is .toString() necessary here?
There was a problem hiding this comment.
Yup, H2O_PYTHON_WHEEL is File. I made it more obvious. thx!
There was a problem hiding this comment.
Actually no even here, we can pass in file directly
|
Thanks for review @mn-mikke. Incorporated the changes in, let's wait for tests |
jakubhava
added a commit
that referenced
this pull request
Apr 18, 2019
(cherry picked from commit ce6a134)
jakubhava
added a commit
that referenced
this pull request
Apr 18, 2019
(cherry picked from commit ce6a134)
jakubhava
added a commit
that referenced
this pull request
Apr 18, 2019
(cherry picked from commit ce6a134)
jakubhava
added a commit
that referenced
this pull request
Apr 18, 2019
(cherry picked from commit ce6a134)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.