[SW-1281] Fix bad representation of predictionCol on H2OMOJOModel #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mn-mikke
previously approved these changes
May 15, 2019
ml/src/main/scala/org/apache/spark/ml/h2o/models/H2OMOJOModel.scala
Outdated
Show resolved
Hide resolved
| @@ -163,7 +163,7 @@ class H2OMOJOModel(override val uid: String) | |||
| val flattenedDF = H2OSchemaUtils.flattenDataFrame(dataset.toDF()) | |||
| val relevantColumnNames = flattenedDF.columns.intersect(getFeaturesCols()) | |||
| val args = relevantColumnNames.map(flattenedDF(_)) | |||
| flattenedDF.select(col("*"), getModelUdf()(struct(args: _*)).as(getOutputCol())) | |||
| flattenedDF.select(col("*"), getModelUdf()(struct(args: _*)).as(getPredictionCol)) | |||
|
|
||
| val parsedParams = metadata.params.asInstanceOf[JsonAST.JObject].obj.map(_._1) | ||
| val allowedParams = instance.params.map(_.name) | ||
| val filteredParams = parsedParams.filter(!allowedParams.contains(_)) |
There was a problem hiding this comment.
WDYT about using theintersect method?
There was a problem hiding this comment.
Thanks just for reference -> as per our discussion in the office, intersect is not a good fit, but diff is
ml/src/main/scala/org/apache/spark/ml/h2o/models/H2OMOJOReader.scala
Outdated
Show resolved
Hide resolved
jakubhava
added a commit
that referenced
this pull request
May 15, 2019
) (cherry picked from commit ae3f9c0)
jakubhava
added a commit
that referenced
this pull request
May 15, 2019
) (cherry picked from commit ae3f9c0)
jakubhava
added a commit
that referenced
this pull request
May 15, 2019
jakubhava
added a commit
that referenced
this pull request
May 15, 2019
) (cherry picked from commit d3f0662)
jakubhava
added a commit
that referenced
this pull request
May 15, 2019
) (cherry picked from commit d3f0662)
jakubhava
added a commit
that referenced
this pull request
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.