[SW-1304] Definition of assembly jar via transitive exclusions #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubhava
reviewed
May 29, 2019
| @@ -52,6 +30,8 @@ shadowJar { | |||
| relocate 'org.eclipse.jetty', 'ai.h2o.org.eclipse.jetty' | |||
| relocate 'org.eclipse.jetty.orbit', 'ai.h2o.org.eclipse.jetty.orbit' | |||
| relocate 'com.google.common', 'ai.h2o.com.google.common' | |||
|
|
|||
| exclude 'www/flow/packs/test-*/**' | |||
There was a problem hiding this comment.
I would create JIRA on H2O project, just to let folks know this can be removed
There was a problem hiding this comment.
Sounds good to me. @michalkurka WDYT about having the testing flows completely separated from h2o-docs examples?
jakubhava
reviewed
May 29, 2019
|
integration tests are failing because they don't have the classes available. |
|
I think that for now, we can put back the examples as they are really small and we can seperate the jars in the next iterations after release. What do you think @mn-mikke ? |
|
Ok, I will put them back and create a separate jira for the removal. |
mn-mikke
added a commit
that referenced
this pull request
May 30, 2019
(cherry picked from commit fc8e908)
mn-mikke
added a commit
that referenced
this pull request
May 30, 2019
(cherry picked from commit fc8e908)
mn-mikke
added a commit
that referenced
this pull request
May 30, 2019
(cherry picked from commit fc8e908)
mn-mikke
added a commit
that referenced
this pull request
May 30, 2019
(cherry picked from commit fc8e908)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.