[SW-1481] Deprecate H2OMOJOModel, H2OMOJOPipelineModel and H2OMOJOSettings in the org.apache.spark package #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mn-mikke
approved these changes
Aug 1, 2019
There was a problem hiding this comment.
LGTM! I really like the direction of these changes.
Just a quick question... Is this change backward-compatible? In other words, what if a algorithm is trained and stored to a H2OMOJOModel in the old namespace and deserialized into one in ai.h2o.sparkling? Does it going to work with MOJOs produced by H2O-3?
| model.setMojoData(mojoData) | ||
| model | ||
| } | ||
| } |
|
Thanks. I finally wanted to move forward with this -> I hope this trick should preserve the backward compatibility https://github.com/h2oai/sparkling-water/pull/1405/files#diff-ab18325d3077d27883c1467d7cb30c19R51 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This build on top of the scoring package. I would like to expose the scoring package with the new namespaces, old one being deprecated
Builds on top of #1403