Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SW-1582] Make sure H2OGLM API is consistent with others and does not use the labmda_ hack #1493

Merged
merged 1 commit into from Sep 2, 2019

Conversation

jakubhava
Copy link
Contributor

No description provided.

@@ -71,10 +71,14 @@ def __init__(self,
withDetailedPredictionCol=False,
featuresCols=[],
convertUnknownCategoricalLevelsToNa=False,
convertInvalidNumbersToNa=False):
convertInvalidNumbersToNa=False,
namedMojoOutputColumns=True,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

namedMojoOutputColumns=True parameter was missing

Copy link
Collaborator

@mn-mikke mn-mikke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakubhava jakubhava merged commit 8532504 into master Sep 2, 2019
@jakubhava jakubhava deleted the jh/sw-1582 branch September 2, 2019 05:13
jakubhava added a commit that referenced this pull request Sep 2, 2019
… use the labmda_ hack (#1493)

(cherry picked from commit 8532504)
jakubhava added a commit that referenced this pull request Sep 2, 2019
jakubhava added a commit that referenced this pull request Sep 2, 2019
…d does not use the labmda_ hack (#1493)

(cherry picked from commit 49d67ca)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants