Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SW-1585] Several H2OGrid Search bug fixes & improvements #1496

Merged
merged 19 commits into from
Sep 5, 2019
Merged

[SW-1585] Several H2OGrid Search bug fixes & improvements #1496

merged 19 commits into from
Sep 5, 2019

Conversation

jakubhava
Copy link
Contributor

@jakubhava jakubhava commented Aug 30, 2019 •
edited

This PR does:

  • Deprecate the old selectBestModelByDecresing in favor of selectBestModelOrdering as that allows the user more explicit control and we can avoid the constant warning
  • Fix bug in strategy param ( link -> strategy )
  • Fix critical bug! updateH2OParams method needs to be called before passing parameters to grid to ensure the H2O parameters object is filled with params from Spark wrapper
  • Ensure we have getter and setter for algo param as algo param was the only one across the API of all algos without getter
  • Improve internal algo handling ( just single algo parameter, no need for the dummy one)
    -> Bug fix! Pass params from python to java before calling updateH2OParameters
  • Don't serialize binary objects

@jakubhava jakubhava changed the title [SW-1585] Improve H2oGridSearch internal handling of Algo + improve API of ordering [SW-1585] Improve H2oGridSearch internal handling of Algo + improve API of ordering + critical bug fix Aug 30, 2019
@jakubhava jakubhava mentioned this pull request Aug 30, 2019
Merged
@jakubhava jakubhava changed the title [SW-1585] Improve H2oGridSearch internal handling of Algo + improve API of ordering + critical bug fix [SW-1585] Several H2OGrid Search bug fixes & improvements Sep 2, 2019
@jakubhava
Copy link
Contributor Author

jakubhava commented Sep 3, 2019 •
edited

@mn-mikke please have a second look, the failed tests are unrelated, otherwise all passed

@jakubhava jakubhava merged commit 9ad0edd into master Sep 5, 2019
jakubhava added a commit that referenced this pull request Sep 5, 2019
@jakubhava
[SW-1585] Several H2OGrid Search bug fixes & improvements (#1496)
a24ba3f 
(cherry picked from commit 9ad0edd)
@jakubhava jakubhava deleted the jh/sw-1585 branch September 5, 2019 15:49
@DinukaH2O DinukaH2O mentioned this pull request May 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mn-mikke mn-mikke mn-mikke left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jakubhava @mn-mikke