Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SW-1623] Fix tests causing intermittent NPE in PySparkling with rollups on external backend #1534

Merged
merged 2 commits into from Sep 18, 2019

Conversation

jakubhava
Copy link
Contributor

@jakubhava jakubhava commented Sep 18, 2019

The failing tests has to ensure that frame updates are inside withLockAndUpdate block

@jakubhava jakubhava changed the title [SW-1623] Fix intermittent NPE in PySparkling with rollups on external backend [SW-1623] Fix tests causing intermittent NPE in PySparkling with rollups on external backend Sep 18, 2019
Copy link
Collaborator

@mn-mikke mn-mikke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good to know about such a thing...

@jakubhava jakubhava merged commit f7e5031 into master Sep 18, 2019
@jakubhava jakubhava deleted the jh/sw-1623 branch September 18, 2019 08:17
jakubhava added a commit that referenced this pull request Sep 18, 2019
…ups on external backend (#1534)

(cherry picked from commit f7e5031)
jakubhava added a commit that referenced this pull request Sep 18, 2019
…ups on external backend (#1534)

(cherry picked from commit f7e5031)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants