[SW-1671] Expose Property for Setting Lifetime of MOJOs in Cache #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mn-mikke
commented
Oct 13, 2019
| private lazy val cleanupRetryTimeout = sparkConf.getInt("spark.ext.h2o.mojo.destroy.timeout", 10 * 60 * 1000) | ||
| private lazy val cleanupRetryTimeout = { | ||
| val sparkConf = SparkSession.builder().getOrCreate().sparkContext.getConf | ||
| sparkConf.getInt("spark.ext.h2o.mojo.destroy.timeout", 10 * 60 * 1000) |
There was a problem hiding this comment.
Here we can't use H2OConf property since the sparkling-water-scoring package doesn't have sparkling-water-core as a dependency and I guess that it's made like that on purpose.
There was a problem hiding this comment.
yup, no H2OConf in scoring package
mn-mikke
added a commit
that referenced
this pull request
Oct 15, 2019
(cherry picked from commit 6be5ea5)
mn-mikke
added a commit
that referenced
this pull request
Oct 15, 2019
(cherry picked from commit 6be5ea5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.