[SW-1708] Simplify distribution of security files #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jakubhava I think this is a great improvement! It seems I got lost in various scenarios. In that case I think you can remove the third parameter from property specification. E.g: https://github.com/h2oai/sparkling-water/pull/1614/files#diff-ed060ffa1e96e1fe4dc30499d7cc9a54L263 |
|
Thanks @mn-mikke! I started playing with SSL communication and got this idea. |
jakubhava
force-pushed
the
jh/sw-1708
branch
from
6a70f3c
to
4b4eeca
Compare
jakubhava
added a commit
that referenced
this pull request
Nov 13, 2019
(cherry picked from commit 994c99c)
jakubhava
added a commit
that referenced
this pull request
Nov 13, 2019
(cherry picked from commit 994c99c)
|
Sorry, I should have mentioned that after the third item from the property spec. The return time of this needs to be modified. |
|
Ah, good catch, let me fix it |
jakubhava
added a commit
that referenced
this pull request
Nov 13, 2019
jakubhava
added a commit
that referenced
this pull request
Nov 13, 2019
(cherry picked from commit 6572d79)
jakubhava
added a commit
that referenced
this pull request
Nov 13, 2019
(cherry picked from commit 6572d79)
|
Fixed, sorry, my bad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal introduce a small cleanup. I thing we can keep one code path for all the cases using this solution.
What do you think? I have missed this during the review.
Maybe there is a reason for doing it like now, I just not see it :)