[SW-1731] Deprecate h2oNodeWebEnabled for external backend #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mn-mikke
reviewed
Nov 25, 2019
| @@ -204,6 +213,12 @@ trait SharedBackendConf { | |||
|
|
|||
| private[backends] def getFileProperties(): Seq[(String, _)] = Seq(PROP_JKS, PROP_LOGIN_CONF) | |||
|
|
|||
| private def logWarningH2ONodeWebEnabledDeprecated(): Unit = { | |||
| if (runsInExternalClusterMode) { | |||
There was a problem hiding this comment.
Shouldn't this hold only if the client is disabled?
There was a problem hiding this comment.
nope, it's on purpose like this, preparing the code for the future steps
jakubhava
added a commit
that referenced
this pull request
Nov 25, 2019
(cherry picked from commit 15f7744)
jakubhava
added a commit
that referenced
this pull request
Nov 25, 2019
(cherry picked from commit 15f7744)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.