[SW-1755] Don't need to stop worker nodes in internal backend, spark takes care of it as it shutdowns the executors #1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubhava
commented
Dec 4, 2019
| @@ -196,7 +196,7 @@ def getOrCreate(spark, conf=None, verbose=True, pre_create_hook=None, h2o_connec | |||
|
|
|||
| def stop(self): | |||
There was a problem hiding this comment.
this is used only for explicit stop by the user, if the user does not call this stop() method in pysparkling, the shutdown hook is called and stop() method on scala side is invoked
…takes care of it as it shutdowns the executors
michalkurka
approved these changes
Dec 4, 2019
mn-mikke
reviewed
Dec 4, 2019
| @@ -364,6 +364,14 @@ External backend configuration properties | |||
| | | | suffix "k", "m" or "g" (e.g. | | |||
| | | | ``450k``, ``3m``) | | |||
| +-------------------------------------------------------+----------------+-------------------------------------+ | |||
| | ``sspark.ext.h2o.external.backend.stop.timeout`` | ``10000ms`` | How long we wait before for proper | | |||
There was a problem hiding this comment.
typo: sspark.ext.h2o.external.backend.stop.timeout
| @@ -364,6 +364,14 @@ External backend configuration properties | |||
| | | | suffix "k", "m" or "g" (e.g. | | |||
| | | | ``450k``, ``3m``) | | |||
| +-------------------------------------------------------+----------------+-------------------------------------+ | |||
| | ``sspark.ext.h2o.external.backend.stop.timeout`` | ``10000ms`` | How long we wait before for proper | | |||
There was a problem hiding this comment.
How long we wait before for proper external backend before we give up on confirmation from worker nodes. Would it be possible to rephrase the sentence?
jakubhava
added a commit
that referenced
this pull request
Dec 4, 2019
…takes care of it as it shutdowns the executors (#1661)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.