Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SW-1943] Remove unnecessary ExternalH2OBackend.verifyH2OClientCloudUp(conf, nodes) check #1832

Merged
merged 2 commits into from
Feb 13, 2020
Merged

[SW-1943] Remove unnecessary ExternalH2OBackend.verifyH2OClientCloudUp(conf, nodes) check #1832

merged 2 commits into from
Feb 13, 2020

Conversation

jakubhava
Copy link
Contributor

@jakubhava jakubhava commented Feb 13, 2020 •
edited

This check does not bring any additional value as we already check the cluster size in ExternalH2OBackend.startH2OClient(hc, nodes)

@jakubhava jakubhava added the next major release Goes into Major release label Feb 13, 2020
mn-mikke
mn-mikke approved these changes Feb 13, 2020
View reviewed changes
Copy link
Collaborator

@mn-mikke mn-mikke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakubhava jakubhava merged commit 804043e into master Feb 13, 2020
@jakubhava jakubhava deleted the jh/SW-1943 branch February 13, 2020 20:47
@DinukaH2O DinukaH2O mentioned this pull request May 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mn-mikke mn-mikke mn-mikke approved these changes

Assignees
No one assigned
Labels
next major release Goes into Major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jakubhava @mn-mikke