[SW-2026] Expose H2OConf Getters and Setters in R #1908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubhava
approved these changes
Mar 2, 2020
jakubhava
reviewed
Mar 3, 2020
| @@ -192,5 +192,5 @@ def setExternalExtraJars(self, paths): | |||
| return self | |||
|
|
|||
| def setExternalCommunicationCompression(self, compression): | |||
| self._jconf.setExternalCommunicationCompression(self, compression) | |||
| self._jconf.setExternalCommunicationCompression(compression) | |||
There was a problem hiding this comment.
It would be good to write tests for all configurations so we avoid these mistakes. I think we already have jira for it, but that is not scope of this PR :)
|
@jakubhava I've manually tested all properties and made some changes, can you take a look one more time? |
jakubhava
approved these changes
Mar 3, 2020
mn-mikke
added a commit
that referenced
this pull request
Mar 4, 2020
(cherry picked from commit 71d9e7c) # Conflicts: # r/src/R/ai/h2o/sparkling/H2OConf.R
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.