[SW-2089] Expose only H2OFrame, hide remaining internal API #1967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubhava
force-pushed
the
jh/SW-2089
branch
2 times, most recently
from
d01a6d0
to
abcb832
Compare
jakubhava
changed the title
mn-mikke
reviewed
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sorry for another mass moving (this time only moving), hopefully last one.
The reason for this is that allmost all classes in
job,frameandmodelpackages inai.h2o.sparklingshould not be user facing. Currently the are public and for example, theH2OModelbeing exposed could really confuse the users.I have therefore moved all the classes which should be internal to
backendpackage and left justH2OFrameinai.h2o.sparkling( As this will be user facing class a lot, I think it should be located conveniently in ai.h2o.sparkling directly).Also we can afford to hide these now as this code hasn't been released so far.
Also I have moved (now private) H2OModel to ml package as it it should be there anyways