[SW-2303] Create Sparkling Py4j Getaway for Steam #2173
Merged
+316
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubhava
force-pushed
the
jh/SW-2303
branch
5 times, most recently
from
68c0901
to
18b0e7c
Compare
jakubhava
changed the title
jakubhava
force-pushed
the
jh/SW-2303
branch
2 times, most recently
from
f6f70d6
to
e462b8a
Compare
bilcus
approved these changes
Jun 25, 2020
core/src/main/scala/ai/h2o/sparkling/backend/SparklingGateway.scala
Outdated
Show resolved
Hide resolved
mn-mikke
reviewed
Jun 25, 2020
core/src/main/scala/ai/h2o/sparkling/backend/SparklingGateway.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/ai/h2o/sparkling/backend/SparklingGateway.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/ai/h2o/sparkling/backend/SparklingGateway.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/ai/h2o/sparkling/backend/SparklingGateway.scala
Outdated
Show resolved
Hide resolved
jakubhava
added
next fix release
and removed
next major release
|
@bilcus I have implemented the automatic port selection. Steam can then obtain the port by reading the following endpoint:
I wanted to keep it generic so the rest of our code doesn't contain references to the gateway code |
|
@jakubhava |
jakubhava
added a commit
that referenced
this pull request
Jun 29, 2020
(cherry picked from commit c840139)
jakubhava
added a commit
that referenced
this pull request
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steam is trying to get rid of Livy.
To achieve this, we can use the Py4j Gateway directly and allow the Spark python client to connect to remote Spark cluster without the Livy complexities.