[SW-352] Flow UI Scala Repl: use paste mode to interpret commands passed through Flow UI #2209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mn-mikke
reviewed
Jul 1, 2020
| try loop() | ||
| catch AbstractOrMissingHandler() | ||
| try { | ||
| val text = Iterator.continually(in.readLine("")).takeWhile(x => x != null).mkString("\n") |
There was a problem hiding this comment.
Why "" is passed to readline?
There was a problem hiding this comment.
Based on the method readLine it seems like it's a prompt to print, but in this case, we don't need to print any, so that is why ""
protected def readOneLine(prompt: String): String = {
echo(prompt)
readOneLine()
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oldtimer JIRA. Implemented while waiting for the K8s tests to finish.
See https://0xdata.atlassian.net/browse/SW-352 for more details