[SW-2496] Fix the Flow link for Databricks Azure #2417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honzasterba
approved these changes
Dec 12, 2020
satai
reviewed
Dec 14, 2020
| @@ -32,7 +33,24 @@ object SparkSpecificUtils extends CrossSparkUtils { | |||
| content: => Seq[Node], | |||
| activeTab: SparkUITab, | |||
| helpText: String): Seq[Node] = { | |||
| UIUtils.headerSparkPage(request, "Sparkling Water", content, activeTab, helpText = Some(helpText)) | |||
| val method = UIUtils.getClass.getMethods.find(m => m.getName == "headerSparkPage").get | |||
There was a problem hiding this comment.
This one is obviously fragile and can break if an overloaded method is added to spark.ui
But I guess that you can live with this?
There was a problem hiding this comment.
Yes, if the method doesn't exist the Spark UI shows an exception if Sparkling Water tab is clicked. For Apache Spark we know that there is such a method. This could if a user deploys SW to a obscure platform with a custom build of Spark which we haven't tested. IMHO, we can live with that.
honzasterba
approved these changes
Dec 14, 2020
mn-mikke
added a commit
that referenced
this pull request
Dec 15, 2020
* [SW-2496] Fix the Flow link for Databricks Azure * spotless apply (cherry picked from commit 5af8b3a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two problems.
More details on:
https://docs.microsoft.com/en-us/azure/databricks/workspace/per-workspace-urlsUIUtils.headerSparkPagemethod in Databricks Spark has more parameters than Apache Spark. I solved the problem via reflection call.Databricks:
request: javax.servlet.http.HttpServletRequest, title: String,content: => Seq[scala.xml.Node], activeTab: org.apache.spark.ui.SparkUITab, helpText: Option[String], showVisualization: Boolean, useDataTables: Boolean, supportScreenshot: BooleanApache:
request: javax.servlet.http.HttpServletRequest, title: String,content: => Seq[scala.xml.Node], activeTab: org.apache.spark.ui.SparkUITab, helpText: Option[String], showVisualization: Boolean, useDataTables: Boolean