[SW-2554] Expose Blending Frame on H2OAutoML #2513
Conversation
.gitignore
Outdated
| ml/src-gen | ||
| scoring/src-gen | ||
| py/src-gen | ||
| py-scoring/src-gen | ||
| r/src-gen |
There was a problem hiding this comment.
FYI, in gitignore , the following pattern will ignore any subfolder named src-gen
src-gen/
There was a problem hiding this comment.
for confirmation (https://git-scm.com/docs/gitignore)
If there is a separator at the beginning or middle (or both) of the pattern, then the pattern is relative to the directory level of the particular .gitignore file itself. Otherwise the pattern may also match at any level below the .gitignore level.
There was a problem hiding this comment.
py-scoring/src-gen worked for me locally, but will change according to your suggestion. Thank you!
There was a problem hiding this comment.
it's just that you were listing all the src-gen modules, and usually you want to exclude those by default.
| automl.fit(trainingDateset) | ||
| leaderboardWithBlendingDataFrameSet = truncateModelId(automl.getLeaderboard()) | ||
|
|
||
| unit_test_utils.assert_data_frames_have_different_values(defaultLeaderboard, leaderboardWithBlendingDataFrameSet) |
There was a problem hiding this comment.
maybe it would be better to compare only the SEs, and verify that the other models are the same (otherwise you can't prove that the difference in SEs is due to the blending frame).
There was a problem hiding this comment.
Will improve that, thank you!
|
PR as such looks good, I don't have yet full understanding why NullableBigDataFrameParam is necessary but that is discussed in another PR. |
Address Sebastian's comments (cherry picked from commit 7e0eb21a85c6e7d1318738f6a594212e5f9ec16e)
Address Sebastian's comments (cherry picked from commit 7e0eb21a85c6e7d1318738f6a594212e5f9ec16e) (cherry picked from commit af3172e)
No description provided.