[SW-2628] Support Java Serialization of NullableDataFrameParams on H2OMOJOModel #2659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rams on H2OMOJOModel
mn-mikke
changed the title
mn-mikke
changed the title
kanech
approved these changes
Jan 31, 2022
| @@ -39,6 +39,7 @@ import org.apache.spark.expose.Logging | |||
| import org.apache.spark.ml.Model | |||
| import org.apache.spark.sql.catalyst.expressions.GenericRowWithSchema | |||
| import org.apache.spark.sql.types._ | |||
| import ai.h2o.sparkling.utils.DataFrameSerializationWrappers._ | |||
There was a problem hiding this comment.
Is the additional import needed here?
There was a problem hiding this comment.
yes, here for example. $(crossValidationMetricsSummary) returns DataFrameSerializationWrapper and imported implicit method toDataFrame will look after the conversion to DataFrame.
krasinski
approved these changes
Feb 1, 2022
ml/src/test/scala/ai/h2o/sparkling/ml/models/H2OMOJOModelTestSuite.scala
Outdated
Show resolved
Hide resolved
DataFrames might be too big gun for such a small task. I went for data frames since binding for Python and R is for free and it's API is well defined and well-known. I'm open to ideas for improvements, but we must be careful with breaking changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.